-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine scripts generation within transaction creation methods #11
Comments
jrwbabylonlab
changed the title
Redesign the lib data structure
Combine scripts generation within transaction creation methods
Aug 22, 2024
Once the improvement is done, it would also resolve below issue out of the box:
and
|
This was referenced Aug 22, 2024
also linking another issue which i believe will be addressed as part of this refactoring #9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now the lib very much like a functional programming where creating/signing a staking tx require u call a method to create scripts, then feed into another method for signing etc.
This has its own downside as the important variables are being passed around which is less secure and prone to bugs with limited validations in place.
The scope of this issue is to have a think about the above problem and assess whether we need a new design for this lib
Recommendation:
createStakingTx
from simple-staking to be abstracted and moved into this lib instead.The text was updated successfully, but these errors were encountered: