Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No script validation when perform staking tx creation #24

Closed
jrwbabylonlab opened this issue Sep 12, 2024 · 1 comment
Closed

No script validation when perform staking tx creation #24

jrwbabylonlab opened this issue Sep 12, 2024 · 1 comment
Assignees

Comments

@jrwbabylonlab
Copy link
Collaborator

All exposed functions like: (stakingTransaction)https://github.com/babylonlabs-io/btc-staking-ts/blob/dev/src/index.ts#L55
take already build scripts as arguments, without validating them. This leaves possibility for
errors for people using the library.
For example they need to remember to check that all keys in our scripts are unique etc.
It would be safer if our api operated on public keys or objects containing public keys.

@jrwbabylonlab
Copy link
Collaborator Author

Close this ticket as it will be addressed in #11

@jrwbabylonlab jrwbabylonlab self-assigned this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant