update buffer check for stakingScript (#75)

babylonlabs-io · Jul 12, 2024 · 97f530c · 97f530c
1 parent 51036c2
commit 97f530c
Showing 1 changed file with 75 additions and 7 deletions.
diff --git a/tests/utils/stakingScript.test.ts b/tests/utils/stakingScript.test.ts
@@ -1,3 +1,4 @@
+import { opcodes, script } from "bitcoinjs-lib";
 import { StakingScriptData } from "../../src/utils/stakingScript";
 
 describe("stakingScript", () => {
@@ -271,7 +272,13 @@ describe("stakingScript", () => {
         magicBytes,
       );
       const timelockScript = stakingScriptData.buildStakingTimelockScript();
-      expect(timelockScript).toBeInstanceOf(Buffer);
+      const decompiled = script.decompile(timelockScript);
+      expect(decompiled).toEqual([
+        pk1,
+        opcodes.OP_CHECKSIGVERIFY,
+        script.number.encode(stakingTimeLock),
+        opcodes.OP_CHECKSEQUENCEVERIFY,
+      ]);
     });
 
     it("should build valid unbonding timelock script", () => {
@@ -286,35 +293,86 @@ describe("stakingScript", () => {
       );
       const unbondingTimelockScript =
         stakingScriptData.buildUnbondingTimelockScript();
-      expect(unbondingTimelockScript).toBeInstanceOf(Buffer);
+      const decompiled = script.decompile(unbondingTimelockScript);
+      expect(decompiled).toEqual([
+        pk1,
+        opcodes.OP_CHECKSIGVERIFY,
+        script.number.encode(unbondingTimeLock),
+        opcodes.OP_CHECKSEQUENCEVERIFY,
+      ]);
     });
 
     it("should build valid unbonding script", () => {
+      const pks = [pk3, pk4, pk5];
       const stakingScriptData = new StakingScriptData(
         pk1, // Staker Pk
         [pk2], // Finality Provider Pks
-        [pk3, pk4, pk5], // covenant Pks
+        pks, // covenant Pks
         2,
         stakingTimeLock,
         unbondingTimeLock,
         magicBytes,
       );
+
+      const sortedPks = pks.sort(Buffer.compare);
+
       const unbondingScript = stakingScriptData.buildUnbondingScript();
-      expect(unbondingScript).toBeInstanceOf(Buffer);
+      const decompiled = script.decompile(unbondingScript);
+
+      const expectedScript = script.decompile(
+        Buffer.concat([
+          script.compile([pk1, opcodes.OP_CHECKSIGVERIFY]),
+          script.compile([
+            sortedPks[0],
+            opcodes.OP_CHECKSIG,
+            sortedPks[1],
+            opcodes.OP_CHECKSIGADD,
+            sortedPks[2],
+            opcodes.OP_CHECKSIGADD,
+            script.number.encode(2),
+            opcodes.OP_NUMEQUAL,
+          ]),
+        ]),
+      );
+
+      expect(decompiled).toEqual(expectedScript);
     });
 
     it("should build valid slashing script", () => {
+      const pks = [pk3, pk4, pk5];
       const stakingScriptData = new StakingScriptData(
         pk1, // Staker Pk
         [pk2], // Finality Provider Pks
-        [pk3, pk4, pk5], // covenant Pks
+        pks, // covenant Pks
         2,
         stakingTimeLock,
         unbondingTimeLock,
         magicBytes,
       );
+
+      const sortedPks = pks.sort(Buffer.compare);
+
       const slashingScript = stakingScriptData.buildSlashingScript();
-      expect(slashingScript).toBeInstanceOf(Buffer);
+      const decompiled = script.decompile(slashingScript);
+
+      const expectedScript = script.decompile(
+        Buffer.concat([
+          script.compile([pk1, opcodes.OP_CHECKSIGVERIFY]),
+          script.compile([pk2, opcodes.OP_CHECKSIGVERIFY]),
+          script.compile([
+            sortedPks[0],
+            opcodes.OP_CHECKSIG,
+            sortedPks[1],
+            opcodes.OP_CHECKSIGADD,
+            sortedPks[2],
+            opcodes.OP_CHECKSIGADD,
+            script.number.encode(2),
+            opcodes.OP_NUMEQUAL,
+          ]),
+        ]),
+      );
+
+      expect(decompiled).toEqual(expectedScript);
     });
 
     it("should build valid data embed script", () => {
@@ -328,7 +386,17 @@ describe("stakingScript", () => {
         magicBytes,
       );
       const dataEmbedScript = stakingScriptData.buildDataEmbedScript();
-      expect(dataEmbedScript).toBeInstanceOf(Buffer);
+      const decompiled = script.decompile(dataEmbedScript);
+      expect(decompiled).toEqual([
+        opcodes.OP_RETURN,
+        Buffer.concat([
+          magicBytes,
+          Buffer.from([0]), // Version byte
+          pk1,
+          pk2,
+          Buffer.from([stakingTimeLock >> 8, stakingTimeLock & 0xff]), // Staking timelock in big endian
+        ]),
+      ]);
     });
 
     it("should build valid staking scripts", () => {