Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Keplr offline signer, minimize interface #117

Merged
merged 3 commits into from
Dec 13, 2024
Merged

feat: Keplr offline signer, minimize interface #117

merged 3 commits into from
Dec 13, 2024

Conversation

gbarkhatov
Copy link
Contributor

  • Minimize Keplr interface
  • Remove the Stargate client Keplr provider dependency. This is still an internal repository npm dependency as will be used later on in tests
  • Returns the offline signer so the outside world (like simple-staking) can use it
  • Adds getWalletProviderName and getWalletProviderIcon

Closes #55 and #63

@gbarkhatov gbarkhatov mentioned this pull request Dec 11, 2024
Closed
@gbarkhatov gbarkhatov linked an issue Dec 11, 2024 that may be closed by this pull request
COSMOS wallets: Stargate client implementation #63
Closed
@gbarkhatov gbarkhatov merged commit c67b9eb into main Dec 13, 2024
1 check passed
@gbarkhatov gbarkhatov deleted the feat/keplr-stargate-minimize branch December 13, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrwbabylonlab jrwbabylonlab jrwbabylonlab approved these changes

@totraev totraev totraev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

COSMOS wallets: Stargate client implementation COSMOS wallets: Minimize Keplr interfaces
3 participants
@gbarkhatov @totraev @jrwbabylonlab