Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: withdrawn state issue #71

Merged
merged 8 commits into from
Nov 26, 2024
Merged

Conversation

gusin13
Copy link
Collaborator

@gusin13 gusin13 commented Nov 25, 2024

Fixes - #67

This pr

  1. fixes race condition while updating delegation state in db. (should use $in to verify while updating that current state is in qualified state)
  2. includes the assumption that expiry checker is bit slow and in meanwhile btc subscription if encounters the spending tx should be able to update the state (expiry checker won't be later able to update/modify the state - related to race condition above)
  3. adds extensive logs in state transitioning - we can keep this temporarily for now in devnet

@gusin13 gusin13 changed the title DNM: only for debugging fix: withdrawn state issue Nov 26, 2024
@gusin13 gusin13 marked this pull request as ready for review November 26, 2024 06:23
Copy link
Collaborator

@jrwbabylonlab jrwbabylonlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusin13 gusin13 merged commit e59c3a3 into main Nov 26, 2024
9 checks passed
@gusin13 gusin13 deleted the gusin13/debug-withdrawn-not-done branch November 26, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants