feat: handle withdrawal after slashing

internal/services/delegation.go

@@ -122,11 +122,11 @@ func (s *Service) processCovenantQuorumReachedEvent(
 		return err
 	}
 
-	proceed, err := s.validateCovenantQuorumReachedEvent(ctx, covenantQuorumReachedEvent)
+	shouldProcess, err := s.validateCovenantQuorumReachedEvent(ctx, covenantQuorumReachedEvent)
 	if err != nil {
 		return err
 	}
-	if !proceed {
+	if !shouldProcess {
 		// Ignore the event silently
 		return nil
 	}
@@ -168,11 +168,11 @@ func (s *Service) processBTCDelegationInclusionProofReceivedEvent(
 		return err
 	}
 
-	proceed, err := s.validateBTCDelegationInclusionProofReceivedEvent(ctx, inclusionProofEvent)
+	shouldProcess, err := s.validateBTCDelegationInclusionProofReceivedEvent(ctx, inclusionProofEvent)
 	if err != nil {
 		return err
 	}
-	if !proceed {
+	if !shouldProcess {
 		// Ignore the event silently
 		return nil
 	}
@@ -225,10 +225,13 @@ func (s *Service) processBTCDelegationUnbondedEarlyEvent(
 		return nil
 	}
 
-	// Get delegation details
-	delegation, err := s.getDelegationDetails(ctx, unbondedEarlyEvent.StakingTxHash)
-	if err != nil {
-		return err
+	delegation, dbErr := s.db.GetBTCDelegationByStakingTxHash(ctx, unbondedEarlyEvent.StakingTxHash)
+	if dbErr != nil {
+		return types.NewError(
+			http.StatusInternalServerError,
+			types.InternalServiceError,
+			fmt.Errorf("failed to get BTC delegation by staking tx hash: %w", dbErr),
+		)
 	}
 
 	// Emit consumer event
@@ -241,8 +244,8 @@ func (s *Service) processBTCDelegationUnbondedEarlyEvent(
 		return err
 	}
 
-	// Start watching for spend
-	if err := s.startWatchingUnbondingSpend(ctx, delegation); err != nil {
+	// Register unbonding spend notification
+	if err := s.registerUnbondingSpendNotification(ctx, delegation); err != nil {
 		return err
 	}
 
@@ -269,24 +272,49 @@ func (s *Service) processBTCDelegationExpiredEvent(
 		return nil
 	}
 
-	// Get delegation details
-	delegation, err := s.getDelegationDetails(ctx, expiredEvent.StakingTxHash)
-	if err != nil {
-		return err
+	delegation, dbErr := s.db.GetBTCDelegationByStakingTxHash(ctx, expiredEvent.StakingTxHash)
+	if dbErr != nil {
+		return types.NewError(
+			http.StatusInternalServerError,
+			types.InternalServiceError,
+			fmt.Errorf("failed to get BTC delegation by staking tx hash: %w", dbErr),
+		)
 	}
 
 	// Emit consumer event
 	if err := s.emitConsumerEvent(ctx, types.StateUnbonding, delegation); err != nil {
 		return err
 	}
 
-	// Handle expiry process
-	if err := s.handleExpiryProcess(ctx, delegation); err != nil {
-		return err
+	// Save timelock expire
+	if err := s.db.SaveNewTimeLockExpire(
+		ctx,
+		delegation.StakingTxHashHex,
+		delegation.EndHeight,
+		types.ExpiredTxType.String(),
+	); err != nil {
+		return types.NewError(
+			http.StatusInternalServerError,
+			types.InternalServiceError,
+			fmt.Errorf("failed to save timelock expire: %w", err),
+		)
 	}
 
-	// Start watching for spend
-	if err := s.startWatchingStakingSpend(ctx, delegation); err != nil {
+	// Update delegation state
+	if err := s.db.UpdateBTCDelegationState(
+		ctx,
+		delegation.StakingTxHashHex,
+		types.StateUnbonding,
+	); err != nil {
+		return types.NewError(
+			http.StatusInternalServerError,
+			types.InternalServiceError,
+			fmt.Errorf("failed to update BTC delegation state: %w", err),
+		)
+	}
+
+	// Register spend notification
+	if err := s.registerStakingSpendNotification(ctx, delegation); err != nil {
 		return err
 	}
 
@@ -326,9 +354,5 @@ func (s *Service) processSlashedFinalityProviderEvent(
 		)
 	}
 
-	// TODO: babylon needs to emit slashing tx
-	// so indexer can start watching for slashing spend
-	// to identify if staker has withdrawn after slashing
-
 	return nil
 }

internal/services/delegation_helpers.go

@@ -16,22 +16,6 @@ import (
 	"github.com/btcsuite/btcd/wire"
 )
 
-// Delegation helper functions
-func (s *Service) getDelegationDetails(
-	ctx context.Context,
-	stakingTxHash string,
-) (*model.BTCDelegationDetails, *types.Error) {
-	delegation, dbErr := s.db.GetBTCDelegationByStakingTxHash(ctx, stakingTxHash)
-	if dbErr != nil {
-		return nil, types.NewError(
-			http.StatusInternalServerError,
-			types.InternalServiceError,
-			fmt.Errorf("failed to get BTC delegation by staking tx hash: %w", dbErr),
-		)
-	}
-	return delegation, nil
-}
-
 func (s *Service) handleUnbondingProcess(
 	ctx context.Context,
 	event *bbntypes.EventBTCDelgationUnbondedEarly,
@@ -77,7 +61,7 @@ func (s *Service) handleUnbondingProcess(
 	return nil
 }
 
-func (s *Service) startWatchingUnbondingSpend(
+func (s *Service) registerUnbondingSpendNotification(
 	ctx context.Context,
 	delegation *model.BTCDelegationDetails,
 ) *types.Error {
@@ -123,41 +107,7 @@ func (s *Service) startWatchingUnbondingSpend(
 	return nil
 }
 
-func (s *Service) handleExpiryProcess(
-	ctx context.Context,
-	delegation *model.BTCDelegationDetails,
-) *types.Error {
-	// Save timelock expire
-	if err := s.db.SaveNewTimeLockExpire(
-		ctx,
-		delegation.StakingTxHashHex,
-		delegation.EndHeight,
-		types.ExpiredTxType.String(),
-	); err != nil {
-		return types.NewError(
-			http.StatusInternalServerError,
-			types.InternalServiceError,
-			fmt.Errorf("failed to save timelock expire: %w", err),
-		)
-	}
-
-	// Update delegation state
-	if err := s.db.UpdateBTCDelegationState(
-		ctx,
-		delegation.StakingTxHashHex,
-		types.StateUnbonding,
-	); err != nil {
-		return types.NewError(
-			http.StatusInternalServerError,
-			types.InternalServiceError,
-			fmt.Errorf("failed to update BTC delegation state: %w", err),
-		)
-	}
-
-	return nil
-}
-
-func (s *Service) startWatchingStakingSpend(
+func (s *Service) registerStakingSpendNotification(
 	ctx context.Context,
 	delegation *model.BTCDelegationDetails,
 ) *types.Error {