Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add event sync skeleton, bootstrap only #2

Merged
merged 3 commits into from
Oct 9, 2024
Merged

feat: add event sync skeleton, bootstrap only #2

merged 3 commits into from
Oct 9, 2024

Conversation

jrwbabylonlab
Copy link
Collaborator

No description provided.

gitferry
gitferry approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@gitferry gitferry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start! Left some suggestions, mostly high level. Can be addressed in subsequent prs

.github/workflows/ci.yml Show resolved Hide resolved
config/config-docker.yml Outdated Show resolved Hide resolved
config/config-local.yml Outdated Show resolved Hide resolved
internal/clients/base/base_client.go Outdated Show resolved Hide resolved
internal/config/bbn.go Outdated Show resolved Hide resolved
internal/clients/bbnclient/interface.go Outdated Show resolved Hide resolved
internal/clients/bbnclient/interface.go Outdated Show resolved Hide resolved
internal/clients/bbnclient/bbnclient.go Outdated Show resolved Hide resolved
internal/services/events.go Outdated Show resolved Hide resolved
internal/services/bootstrap.go Show resolved Hide resolved
@jrwbabylonlab jrwbabylonlab merged commit fa87df6 into main Oct 9, 2024
7 of 9 checks passed
@jrwbabylonlab jrwbabylonlab deleted the event-sync-skeleton branch October 9, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitferry gitferry gitferry approved these changes

@jeremy-babylonlabs jeremy-babylonlabs Awaiting requested review from jeremy-babylonlabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrwbabylonlab @gitferry