Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a CI workflow to publish the bitcoinsim image #19

Merged
merged 5 commits into from
Oct 19, 2024
Merged

feat: add a CI workflow to publish the bitcoinsim image #19

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8911f33
feat: add a ci workflow to publish the bitcoinsim image
lesterli Oct 18, 2024
6006402
fix: typo
lesterli Oct 18, 2024
46e6e39
fix: wrapper.sh not found
lesterli Oct 18, 2024
a6c9a2e
Merge branch 'feat/fix-babylon-deployment' into feat/ci-workflow-bitc…
lesterli Oct 19, 2024
94e37d0
chore: remove testnet
lesterli Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: docker_publish

on:
push:
paths:
- 'contrib/images/bitcoindsim/**'

jobs:
docker_pipeline:
needs: []
uses: babylonlabs-io/.github/.github/workflows/[email protected]
secrets: inherit
with:
publish: true
dockerfile: ./contrib/images/bitcoindsim/Dockerfile
dockerContext: ./contrib/images/bitcoindsim
repoName: bitcoindsim
2 changes: 1 addition & 1 deletion contrib/images/bitcoindsim/wrapper.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if [[ ! -d "$BITCOIN_DATA" ]]; then
fi
echo "Generating bitcoin.conf file at $BITCOIN_CONF"
if [[ "$BITCOIN_NETWORK" == "testnet" ]]; then
NETWORK_LABEL="test"
NETWORK_LABEL="test" # [test] not [testnet] for testnet3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this mean?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment said for the Bitcoin network we need to set test for testnet3 in the bitcoin.conf.
anyway, we can remove it since we only support signet now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is bitcoin.conf? i cannot find it

else
NETWORK_LABEL="$BITCOIN_NETWORK"
fi
Expand Down
4 changes: 2 additions & 2 deletions deployments/finality-gadget-integration-op-l2/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ start-babylon:
else \
echo "Unsupported bitcoin network: $(BITCOIN_NETWORK)"; \
fi
.PHONY: start
.PHONY: start-babylon

stop-babylon:
@$(DOCKER) compose -f artifacts/docker-compose.yml down -v
Expand All @@ -204,7 +204,7 @@ stop-babylon:
else \
echo "Unsupported bitcoin network: $(BITCOIN_NETWORK)"; \
fi
.PHONY: stop
.PHONY: stop-babylon

# Run independent steps
# TODO: remove these after testing
Expand Down