refactor instantiation logic #94
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
approved these changes
Dec 6, 2024
Comment on lines
+49
to
+53
| pub fn get_babylon_sdk_params(querier: &QuerierWrapper) -> Result<Params, StdError> { | ||
| let params = querier.query_grpc(QUERY_PARAMS_PATH.to_owned(), Binary::new("".into()))?; | ||
| let params = QueryParamsResponse::from(params).params; | ||
| Ok(params) | ||
| } |
There was a problem hiding this comment.
I think this approach is not without merit, but it would be much simpler IMO to just pass the needed params during instantiation. The contracts have a clear dependencies, so it's just a matter of instantiating them in the right order and pass required parameters (other contracts' addresses) between them at instantiation.
Comment on lines
-20
to
-21
| pub babylon: Addr, | ||
| pub staking: Addr, |
There was a problem hiding this comment.
I would just keep these, and pass / set them during instantiation.
Comment on lines
+263
to
+264
| pub fn get_activated_height(querier: &QuerierWrapper) -> StdResult<u64> { | ||
| let params = get_babylon_sdk_params(querier)?; |
There was a problem hiding this comment.
Nit: This is good for encapsulation, but bad for performance. In any case, since you already have it why not pass the entire Config by reference instead?
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.