F/btc-lc feature
#100
F/btc-lc feature
#100
Conversation
|
Since we need to split BTC light client into another contract (#53), wdyt we go straight to that? Maintaining such a new feature would be very challenging and at the end of the day we will be removing this feature. |
|
May be. I did this to continue working on the rewards distribution feature, as the size limit was blocking me. I would say let's merge this to unblock stuff, and work on the Another option could be to leave this on a branch. But, rewards distribution requires this, so not sure about it. |
|
In any case, we can merge this and then revert the entire squashed commit when working on the |
To unblock can we temporarily enlarge the size limit of wasm contract? This seems cleaner |
|
It seems, but I'm afraid it would involve changing the wasmd source code, i.e. we cannot directly use the binary artefact anymore. I'll take a look. |
Not really, we did this once in Babylon SDK actually by setting some public variables. |
|
Found it, you can set https://github.com/CosmWasm/wasmd/blob/c2b31e0bc0f4c1286ce2431553bd8cf0a66774db/x/wasm/types/validation.go#L24-L25 to something larger when initialising bcd app (as big as 3MB iirc) |
|
You're right, I was confused between wasmd and wasmvm. Thanks. |
Introduce a
btc-lcfeature flag, to remove BTC light client functionality from the Babylon contract.babylon-contracthas reached the wasm size limit (800KB), and to continue introducing features we must either move functionality to another contract, or reduce its size by removing features.Here we do the second approach, which can in any case serve as a step towards the first one.