chores/212 additional ordinals tests #217
Conversation
jeremy-babylonlabs
force-pushed
the
chores/212-additional-ordinals-tests
branch
from
8b23838 to
1890cfd
Compare
| } | ||
|
|
||
| // Test case 3: Invalid UTXO txid should return an error | ||
| func TestVerifyUtxosEndpointWithMixedUTXOs(t *testing.T) { |
There was a problem hiding this comment.
aren't we checking the txId at the handler level? Why do we need to mock the unisat and ordinal service response if the request will return error at handler layer?
| mockUnisat.On("FetchInscriptionsUtxosByAddress", mock.Anything, mock.Anything, mock.Anything). | ||
| Return(mockUnisatResponse, nil).Once() | ||
| mockUnisat.On("FetchInscriptionsUtxosByAddress", mock.Anything, mock.Anything, mock.Anything). | ||
| Return([]*unisat.UnisatUTXO{}, nil) |
There was a problem hiding this comment.
Is the purpose here to test the unisat pagination? then it would be best to have at least 1 item returned fromt he second response.
also it would be better to replace the mock.Anything with the actual cursor and limit value so that we ensure the pagination works
| } | ||
|
|
||
| for _, u := range response.Data { | ||
| unisatUTXO, exists := unisatUTXOMap[u.TxId] |
There was a problem hiding this comment.
this is not true. Unisat does not return all utxos.
unisat only return the utxos that has ordinals for a particular address.
I.e len(response.Data) != len(unisat response).
| } | ||
|
|
||
| // Test case 5: Unisat service return error, return error | ||
| func TestVerifyUtxosEndpointUnisatServiceErrorReturnError(t *testing.T) { |
There was a problem hiding this comment.
nit: could you double check if we using UTXOs or Utxos in the codebase. I don't remember
| callCount := 0 | ||
| var mockUnisatResponses [][]*unisat.UnisatUTXO | ||
| mockUnisat := new(mocks.UnisatClientInterface) | ||
| mockUnisat.On("FetchInscriptionsUtxosByAddress", mock.Anything, mock.Anything, mock.Anything). |
There was a problem hiding this comment.
I'm not sure the below tests are relevant to us.
What i thought this test would be is:
- Override the config
c.config.limitto be a much smaller number - Send a post request
- the mocked response from unisat return
c.config.limitmany item. - triggered another call, that return the remaining items. so in total, we have over c.config.limit items from unisat
- based on all the returned values from unisat, filter the post request utxos
| @@ -336,3 +336,5 @@ func buildActiveStakingEvent(t *testing.T, numOfEvenet int) []*client.ActiveStak | |||
| } | |||
| return activeStakingEvents | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
nit: one more extra line
|
addressed in other PR |
No description provided.