Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ordinal endpoint and tests #207

Merged
merged 1 commit into from
Jul 24, 2024
Merged

add ordinal endpoint and tests #207

merged 1 commit into from
Jul 24, 2024

Conversation

jeremy-babylonlabs
Copy link
Contributor

Config changes:
added
external:ordinal_api_url

TODO: add config in service deployment

Tests:
happy path:

  • One UTXO
  • Multiple UTXOs

error paths:

  • Invalid Input Format
  • Invalid Input Format
  • UTXOs not found

@jeremy-babylonlabs jeremy-babylonlabs self-assigned this Jul 18, 2024
@jrwbabylonlab jrwbabylonlab requested a review from vitsalis July 18, 2024 11:04
vitsalis
vitsalis requested changes Jul 18, 2024
View reviewed changes
internal/config/config.go Outdated Show resolved Hide resolved
internal/api/routes.go Outdated Show resolved Hide resolved
internal/types/ordinals.go Outdated Show resolved Hide resolved
internal/types/ordinals.go Outdated Show resolved Hide resolved
internal/types/ordinals.go Outdated Show resolved Hide resolved
internal/services/ordinals.go Outdated Show resolved Hide resolved
internal/types/ordinals.go Outdated Show resolved Hide resolved
internal/types/ordinals.go Outdated Show resolved Hide resolved
internal/types/ordinals.go Outdated Show resolved Hide resolved
internal/services/ordinals.go Outdated Show resolved Hide resolved
@jeremy-babylonlabs jeremy-babylonlabs marked this pull request as draft July 18, 2024 17:33
vitsalis
vitsalis reviewed Jul 22, 2024
View reviewed changes
internal/types/ordinals.go Outdated Show resolved Hide resolved
internal/api/handlers/ordinals.go Show resolved Hide resolved
internal/api/handlers/ordinals.go Outdated Show resolved Hide resolved
internal/api/handlers/ordinals.go Outdated Show resolved Hide resolved
internal/api/handlers/ordinals.go Show resolved Hide resolved
internal/clients/unisat/unisat.go Outdated Show resolved Hide resolved
internal/config/ordinals.go Outdated Show resolved Hide resolved
internal/config/unisat.go Outdated Show resolved Hide resolved
internal/services/ordinals.go Show resolved Hide resolved
internal/services/ordinals.go Outdated Show resolved Hide resolved
@jeremy-babylonlabs jeremy-babylonlabs marked this pull request as ready for review July 22, 2024 16:42
vitsalis
vitsalis reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@vitsalis vitsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. We should update the README to include information on the new configuration and the fact that it is optional. New people onboarding will see our default configuration files and expect that it is a requirement. This can happen in a different PR to not block this one.

cmd/staking-api-service/main.go Outdated Show resolved Hide resolved
internal/api/routes.go Show resolved Hide resolved
internal/api/server.go Show resolved Hide resolved
internal/clients/clients.go Outdated Show resolved Hide resolved
internal/clients/ordinals/ordinals.go Outdated Show resolved Hide resolved
internal/clients/unisat/README.md Outdated Show resolved Hide resolved
internal/clients/unisat/unisat.go Show resolved Hide resolved
internal/services/ordinals.go Show resolved Hide resolved
internal/services/ordinals.go Outdated Show resolved Hide resolved
tests/datagen.go Outdated Show resolved Hide resolved
@jrwbabylonlab jrwbabylonlab requested a review from vitsalis July 24, 2024 04:09
@jrwbabylonlab jrwbabylonlab force-pushed the feat/ordinals-verify-utxos branch 2 times, most recently from 5c4cdbf to 4a53add Compare July 24, 2024 04:15
@jrwbabylonlab jrwbabylonlab force-pushed the feat/ordinals-verify-utxos branch from 4a53add to 9aaf1de Compare July 24, 2024 04:20
vitsalis
vitsalis approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@vitsalis vitsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! minor comments

cmd/staking-api-service/main.go Show resolved Hide resolved
config/config-docker.yml Show resolved Hide resolved
internal/config/assets.go Show resolved Hide resolved
internal/services/ordinals.go Show resolved Hide resolved
@jrwbabylonlab
Copy link
Collaborator

i'm merging this PR.
@jeremy-babylonchain i will leave the two pending tasks to you if that's ok.
#212
#213

@jrwbabylonlab jrwbabylonlab merged commit 7202cd8 into main Jul 24, 2024
2 checks passed
@jrwbabylonlab jrwbabylonlab deleted the feat/ordinals-verify-utxos branch July 24, 2024 09:49
@jeremy-babylonlabs
Copy link
Contributor Author

i'm merging this PR. @jeremy-babylonchain i will leave the two pending tasks to you if that's ok. #212 #213

Yep, will raise another PR for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KonradStaniec KonradStaniec KonradStaniec left review comments

@vitsalis vitsalis vitsalis approved these changes

@jrwbabylonlab jrwbabylonlab Awaiting requested review from jrwbabylonlab

Assignees

@jeremy-babylonlabs jeremy-babylonlabs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeremy-babylonlabs @jrwbabylonlab @vitsalis @KonradStaniec