Unmarshalling perf #466
Open
Unmarshalling perf #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
70
to
78
| func (sig *BIP340Signature) Unmarshal(data []byte) error { | ||
| newSig := BIP340Signature(data) | ||
|
|
||
| // ensure that the bytes can be transformed to a *schnorr.Signature object | ||
| // this includes all format checks | ||
| _, err := newSig.ToBTCSig() | ||
| if err != nil { | ||
| return errors.New("bytes cannot be converted to a *schnorr.Signature object") | ||
| } | ||
|
|
||
| *sig = data |
There was a problem hiding this comment.
Given that we don't perform verification here, NewBIP340Signature won't perform any verification either. Since NewBIP340Signature will be the function that takes inputs from the external users, we need to move the verification removed here to NewBIP340Signature.
x/btcstaking/types/msg.go
Outdated
Comment on lines
172
to
174
| _, err := m.UnbondingTxSig.ToBTCSig() | ||
|
|
||
| if err != nil { |
There was a problem hiding this comment.
Suggested change
| _, err := m.UnbondingTxSig.ToBTCSig() | |
| if err != nil { | |
| if _, err := m.UnbondingTxSig.ToBTCSig(); err != nil { |
IIRC this is the practice recommended by Go. Same comments for other places in this file
SebastianElvis
approved these changes
Feb 12, 2024
KonradStaniec
force-pushed
the
unmarshalling-perf
branch
from
db0bcb9 to
3eaede2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pr in spirit of - #441
Latest flamegraphs from load testing shown that, deserialzing btc transaction and signatures takes most time in code paths which retrieve a lot of delegations. This pr removes some unnecessary checks from db perspective.
This is not proper solution, but it can be some kind of stop-gap if we we would need around 20% perf boost (based on begin block benchmarks). It is also backward compatbile with current testnet and all the programs so this is easy gain.