Skip to content

Commit

Permalink
chore: address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
RafilxTenfen committed Jul 26, 2024
1 parent 9d9ab68 commit df5cac9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
3 changes: 2 additions & 1 deletion contrib/images/Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
RELAYER_TAG := $(shell grep '^ENV RELAYER_TAG' cosmos-relayer/Dockerfile | cut -f3 -d\ )
BABYLON_FULL_PATH := $(shell git rev-parse --show-toplevel)
BABYLON_VERSION_BEFORE_UPGRADE ?= a33a3344bb44bde2f3374d3cbf919abb942c341a

all: babylond cosmos-relayer

Expand All @@ -9,7 +10,7 @@ babylond: babylond-rmi
babylond-before-upgrade:
docker rmi babylonchain/babylond-before-upgrade 2>/dev/null; true && \
docker build --tag babylonchain/babylond-before-upgrade -f babylond/Dockerfile \
--build-arg VERSION="a33a3344bb44bde2f3374d3cbf919abb942c341a" ${BABYLON_FULL_PATH}
--build-arg VERSION="${BABYLON_VERSION_BEFORE_UPGRADE}" ${BABYLON_FULL_PATH}

babylond-rmi:
docker rmi babylonchain/babylond 2>/dev/null; true
Expand Down
4 changes: 0 additions & 4 deletions contrib/images/babylond/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
FROM golang:1.21 AS build-env

# Customize to your build env

# TARGETPLATFORM should be one of linux/amd64 or linux/arm64.
ARG TARGETPLATFORM="linux/amd64"
# Version to build. Default is empty
ARG VERSION

Expand Down
6 changes: 4 additions & 2 deletions test/e2e/software_upgrade_e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,11 @@ func (s *SoftwareUpgradeVanillaTestSuite) TestUpgradeVanilla() {
n, err := chainA.GetDefaultNode()
s.NoError(err)

// makes sure that the upgrade was acutally executed
expectedUpgradeHeight := int64(25)

// makes sure that the upgrade was actually executed
resp := n.QueryAppliedPlan("vanilla")
s.EqualValues(int64(25), resp.Height, "the plan should be applied at the height 25")
s.EqualValues(expectedUpgradeHeight, resp.Height, "the plan should be applied at the height 25")

fps := n.QueryFinalityProviders()
s.Len(fps, 1, "it should have one finality provider, since the vanilla upgrade just added a new one")
Expand Down

0 comments on commit df5cac9

Please sign in to comment.