finality: sudo message for BeginBlock
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
approved these changes
Jun 10, 2024
Comment on lines
+23
to
+24
| // UpdateParams updates the params. | ||
| func (ms msgServer) UpdateParams(goCtx context.Context, req *types.MsgUpdateParams) (*types.MsgUpdateParamsResponse, error) { |
There was a problem hiding this comment.
Nit: Shouldn't this belong to a different / independent PR?
Or this is needed to get the contracts addresses?
There was a problem hiding this comment.
It is necessary as eventually one might need to trigger gov prop to call this message in order to set up the Babylon contract addresses. It's not a big change -- most things about this message handler are copied from Babylon e.g., https://github.com/babylonchain/babylon/blob/2a7c91d6f1649912f14667d3a3ee6a2c1792c3d9/x/btccheckpoint/keeper/msg_server.go#L97-L114
|
CI failed due to config reasons. Will fix in separate PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
This PR provides sudo message
BeginBlockfor Babylon contracts. The sudo message will be sent to BTC staking contract upon eachBeginBlock.To test, run
make test-e2e. Note that the wasm files are generated on https://github.com/babylonchain/babylon-contract/pull/123