Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add GPT-4o model (with caveats) #6

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Feat: Add GPT-4o model (with caveats) #6

merged 5 commits into from
Aug 6, 2024

Conversation

Ahmad-A0
Copy link
Contributor

@Ahmad-A0 Ahmad-A0 commented Aug 4, 2024

This PR adds the gpt-4o-mini model, which can be set with the string GPT4OMini in the config.

model = "GPT4OMini"

I also made a change to disable the vqd caching and retrieval functionality. It seems DuckDuckGo have changed something on their backend, which causes errors with the newer model. This change doesn't seem to effect any of the model outputs, I may just be misunderstanding something so please do take a look.

    pub fn get_last_vqd<'a, T: From<&'a String>>(self: &'a Self) -> Option<T> {
        None
        /*if self.last_vqd_time - (chrono::Local::now().timestamp_millis() as u64) < 60000 {
            Some((&self.last_vqd).into())
        } else {
            None
        } */
    }

@Ahmad-A0 Ahmad-A0 closed this Aug 4, 2024
@b1ek
Copy link
Owner

b1ek commented Aug 5, 2024

whys it closed? looks good enough to me

@b1ek b1ek reopened this Aug 5, 2024
src/cache.rs Outdated Show resolved Hide resolved
Copy link
Owner

@b1ek b1ek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will merge it manually when its ok

@b1ek b1ek merged commit ffa2bc9 into b1ek:main Aug 6, 2024
@pokegamer5547
Copy link

pokegamer5547 commented Sep 23, 2024

Hello, i'm having this issue when using gpt4omini model (tho it works but only sometimes) i'm using latest dev and compiled it myself (i'm on android). Idk if it's related to this change
Screenshot_20240923-110212_Termux_1

@b1ek
Copy link
Owner

b1ek commented Sep 23, 2024

@pokegamer5547 it has something to do with their API. if you have been abusing it then you are hitting the rate limit, but if you havent then it needs to be looked into

you should like open an issue for it

@pokegamer5547
Copy link

@pokegamer5547 it has something to do with their API. if you have been abusing it then you are hitting the rate limit, but if you havent then it needs to be looked into

you should like open an issue for it

It's first time i used this and even on first try i had this issue. And i'm able to access on browser just time. And yes you're right, i'll open new issue for it. Even now after few hours and from other phone too on different network i'm having same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants