-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PyPI Integrations for Release Upload #72
Conversation
CI fails a couple of tests:
Uncertain if this is because the data being returned has changed or if a function isn't parsing out the data returned correctly. Additional investigation needed. |
Confirmed with @rajadain that the data being returned changed for the affected tests and that we should simply update the tests to match expected return. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! But we need to update the GitHub Actions to point to production PyPI before this can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nice work!
Overview
The
python-omgeo
Python packages is published via the Azavea PyPI account, however recent builds of these projects are failing because PyPI has changed from username/password authentication to token based and trusted-publisher based authentication. This PR will address updating the integration.Closes #71
Demo
The Problem:
Proposed Solution:
Notes
workflow.yml
file by removing thewith:
clause from the Upload release to TestPyPI step and update the step name accordingly. This will switch the upload from TestPyPI to PyPI.Testing Instructions
TestPyPI Testing - Manual Release:
Note
Example of successful manual test: GitHub Action Release #6
Note that
upload
was misspelled in this test run, it has since been corrected.release/test
with the tagstest
, then push upChecklist
CHANGES.txt
has been updated