Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup crash in delete and node lat lons not being written to 7 decimal places #54

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Fixup crash in delete and node lat lons not being written to 7 decimal places #54

merged 3 commits into from
Oct 28, 2020

Conversation

CloudNiner
Copy link
Contributor

Fixes two outstanding issues:

  1. Occasional continuing crashes in rebuild_old_metadata due to old locs not being available.
  2. Nodes weren't rewriting their lat lons to 7 decimal places, we were only augmenting old nodes

Fixes the issues by:

  • Remove any element from the action list that was created and then deleted within the diff interval. Doesn't handle elements that are created, modified, then deleted ATM, this would require additional tracking. Opened Remove elements from diff that are created, then modified, then deleted within a diff interval #53.
  • Only augment elements within the augment loop. We were augmenting nodes in rebuild_old_metadata.
  • Consistently use augment_nd() in all possible spots so we consistently see the No loc found for node error everywhere it can occur
  • Call augment_nd() on nodes in augment()

These changes in aggregate made diff 4215825 jump from 1771/3076 equal elements to 2276/3076, a 20% increase. The remaining elements that are different are all elements that contain old nodes and thus "?" for their metadata attributes.

@CloudNiner
Fix crash in delete elems when no old node location
215ad85
@CloudNiner
Skip elements that are created then deleted
2070563 
Just like Overpass
@CloudNiner
Refactor to consistently use augment_nd
224c456 
Remove from rebuild_old_element, we shouldn't
be adding lat lons there, defer until augment
step.

Use augment_nd in augment if type is node to
ensure we're rewriting lat lons with 7 decimals

Use augment_nd consistently anywhere we get_lat_lon
@CloudNiner CloudNiner force-pushed the fixup/awf/crash-in-delete branch from 219b025 to 224c456 Compare October 27, 2020 22:30
@CloudNiner CloudNiner mentioned this pull request Oct 27, 2020
Open
@CloudNiner CloudNiner merged commit 7c2765c into master Oct 28, 2020
@CloudNiner CloudNiner deleted the fixup/awf/crash-in-delete branch October 28, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CloudNiner