This repository has been archived by the owner on Jul 6, 2024. It is now read-only.
Adding NOHTMLRENDER build flag #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if it's possible to protect the upload of firmware with credentials, I would prefer to totally disable the update form, when firmware is published automatically via a script.
In addition, there would be a saving of memory space 4% on my ESP-32, due to the HTML template not loaded.
To ensure the template is not embedded within the build, the best I found is to use build flag.
Example in my platformio.ini file:
build_flags = -D NOHTMLRENDEROf course, no flag = no change in the current behavior.
In the proposed readme change, I didn't include how to add a build flag, because I assume it's easy to find how to.
btw thanks a lot for this awesome lib! :)