Open external links in new tab; Add drop down link to referenced section on FAQ page #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is some accessibility things that should be kept in consideration if we allow links to open into a new tab since it breaks the default behavior of links. Older screen readers have a difficult time opening new tabs, although new ones will tell you when a new tab opens. http://libux.co/links-should-open-in-the-same-window/ I would argue that we should allow users to decide if they would like links to open in new tabs, rather than making the decision for them. |
|
tks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's best practice, both for SEO reasons and UX, to have external links open in a new tab. (We don't want users to lose your valuable website when clicking through to a resource.)
I also added a drop down link to the referenced "Afgan and Iraqi SIVs" section on the FAQ page for ease of navigation.