Fix: ValueError when FA + Mistral when padding_side=right #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
NanoCode012
commented
Oct 5, 2023
NanoCode012
commented
- Test
cvinker
approved these changes
Oct 5, 2023
|
Ok, it should work. Unfortunately, don't have the GPU to test. Keep oom-ing locally. |
|
I'm a bit unclear why the Error did not crop up during E2E tests. We should look into this later. |
winglian
approved these changes
Oct 5, 2023
8 tasks
mkeoliya
pushed a commit
to mkeoliya/axolotl
that referenced
this pull request
Dec 15, 2023
…-cloud#681) * Fix: ValueError when FA + Mistral when padding_side=right * fix: remove tokenizer class check
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Fix: ValueError when FA + Mistral when padding_side=right * fix: remove tokenizer class check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.