Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support custom field for completion from yml #580

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Conversation

winglian
Copy link
Collaborator

you can now specify an alternate field from the dataset to use instead of text as the completion text

@winglian
Copy link
Collaborator Author

verified this against the tiny-textbooks dataset

Copy link
Collaborator

@NanoCode012 NanoCode012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's a very clean code, I think it seems quite complicated just to change the key for the completion dataset.

Personally, I would just write a simple python script to rename the key of the dataset..

README.md Show resolved Hide resolved
@winglian winglian merged commit f7a2263 into main Sep 15, 2023
3 checks passed
@winglian winglian deleted the completion-custom-field branch September 15, 2023 11:48
mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
* support custom field for completion from yml

* remove legacy completion check and add doc

* update README docs
djsaunde pushed a commit that referenced this pull request Dec 17, 2024
* support custom field for completion from yml

* remove legacy completion check and add doc

* update README docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants