use fastchat conversations template #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winglian
force-pushed
the
fastchat-conversations
branch
from
98cc645 to
4738fea
Compare
8 tasks
winglian
force-pushed
the
fastchat-conversations
branch
from
b051681 to
2ba8830
Compare
winglian
force-pushed
the
fastchat-conversations
branch
from
654bbcc to
243d9e1
Compare
NanoCode012
reviewed
Sep 27, 2023
| @@ -443,6 +443,7 @@ datasets: | |||
| data_files: # Optional[str] path to source data files | |||
| shards: # Optional[int] number of shards to split data into | |||
| name: # Optional[str] name of dataset configuration to load | |||
| conversation: # Optional[str] fastchat conversation type, only used with type: sharegpt | |||
There was a problem hiding this comment.
Suggested change
| conversation: # Optional[str] fastchat conversation type, only used with type: sharegpt | |
| conversation: # Optional[str] fastchat conversation type, only used with type: sharegpt. See options: https://github.com/lm-sys/FastChat/blob/main/fastchat/conversation.py |
| import fastchat.conversation | ||
|
|
||
| fastchat.conversation.Conversation.get_turns = get_turns | ||
| fastchat.conversation.Conversation.get_prompt = get_prompt |
There was a problem hiding this comment.
May I ask what changed to need this patch? I see a lot of similarity Conversation from fschat.
There was a problem hiding this comment.
Yeah. Mostly the ability to reuse most of the predefined conversation types defined thwre
|
Oh, didn't see it got merged while I was checking it |
8 tasks
mkeoliya
pushed a commit
to mkeoliya/axolotl
that referenced
this pull request
Dec 15, 2023
* use fastchat conversations template * require fastchat (fschat) pip install * handle roles dynamically from conversation * tweak fastchat conversation with a monkeypatch to get individual turns * fix up so it works with multiple conversation styles, and don't strip the turns * fix sharegpt fixture now that we're using a more correct tokenization * use a new prompter and support fastchat conversation type * use sharegpt from prompt strategies now * update docs, add chatml template * add a newline after im_end token * ensure we correctly set system message * update per PR feedback to handle deprecated sharegpt types * don't add duplicate wandb req * make sharegpt fields configurable from yml * llama2 fixes * don't fail fatally when turns are improper
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
* use fastchat conversations template * require fastchat (fschat) pip install * handle roles dynamically from conversation * tweak fastchat conversation with a monkeypatch to get individual turns * fix up so it works with multiple conversation styles, and don't strip the turns * fix sharegpt fixture now that we're using a more correct tokenization * use a new prompter and support fastchat conversation type * use sharegpt from prompt strategies now * update docs, add chatml template * add a newline after im_end token * ensure we correctly set system message * update per PR feedback to handle deprecated sharegpt types * don't add duplicate wandb req * make sharegpt fields configurable from yml * llama2 fixes * don't fail fatally when turns are improper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the
vicuna_v1.1Conversations template from the fastchat package. This will make it easier to extend additional conversation types since we can simply load an already registered conversation format template.