document that packaging needs to be installed before flash-attn #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoCode012
approved these changes
Sep 12, 2023
| @@ -140,7 +142,8 @@ accelerate launch scripts/finetune.py examples/openllama-3b/lora.yml \ | |||
| git clone https://github.com/OpenAccess-AI-Collective/axolotl | |||
| cd axolotl | |||
|
|
|||
| pip3 install -e . | |||
| pip3 install packaging | |||
| pip3 install -e .[flash-attn] | |||
| pip3 install protobuf==3.20.3 | |||
| pip3 install -U --ignore-installed requests Pillow psutil scipy | |||
There was a problem hiding this comment.
You can merge these other installs together.
There was a problem hiding this comment.
the problem is that if packaging isn't installed first, trying to install at the same time fails for flash-attn.
|
Do we also need to mention that |
I haven't seen that ninja has been problematic, but we can address in another pr |
mkeoliya
pushed a commit
to mkeoliya/axolotl
that referenced
this pull request
Dec 15, 2023
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.