Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use flash_attn xentropy when available #525

Merged
merged 2 commits into from
Sep 4, 2023
Merged

use flash_attn xentropy when available #525

merged 2 commits into from
Sep 4, 2023

Conversation

tmm1
Copy link
Collaborator

@tmm1 tmm1 commented Sep 4, 2023

uses xentropy module if installed

see memory improvement numbers in Dao-AILab/flash-attention#475 (comment)

@tmm1 tmm1 force-pushed the flash-attn-xentropy branch from e37d3b2 to cdeba07 Compare September 4, 2023 04:16
Copy link
Collaborator

@winglian winglian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go after adding a warning.

@tmm1 tmm1 force-pushed the flash-attn-xentropy branch from b9c1b45 to abd4f9a Compare September 4, 2023 21:45
@tmm1 tmm1 merged commit 5fe30b1 into main Sep 4, 2023
@IgnacioFDM
Copy link

Maybe this and #526 should be added to the Dockerfile?

@winglian winglian deleted the flash-attn-xentropy branch October 23, 2023 15:21
@winglian winglian restored the flash-attn-xentropy branch October 23, 2023 15:21
@winglian winglian deleted the flash-attn-xentropy branch October 23, 2023 15:21
mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
* use flash_attn xentropy when available

* log when xentropy is not found
djsaunde pushed a commit that referenced this pull request Dec 17, 2024
* use flash_attn xentropy when available

* log when xentropy is not found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants