Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(callback): Remove old peft saving code #510

Merged

Conversation

NanoCode012
Copy link
Collaborator

Previously, peft does not save the adapter, hence we needed this code. After peft updated a while back, this callback unnecessarily saves the adapter another time.

We can now remove it.

@NanoCode012 NanoCode012 marked this pull request as draft August 31, 2023 05:57
@NanoCode012
Copy link
Collaborator Author

Per winglian's comment in Discord, relora might need this code. I think I need some confirmation what relora usually saves at as I haven't trained one before. And if it's necessary for only relora, we can change the condition for only then.

@NanoCode012
Copy link
Collaborator Author

Seems like relora already saves its own adapter_model

image

@NanoCode012 NanoCode012 force-pushed the chore/remove_peftcallback branch from d1c9683 to 1e2bd08 Compare September 21, 2023 07:19
@NanoCode012
Copy link
Collaborator Author

Rebased!

@NanoCode012 NanoCode012 marked this pull request as ready for review September 21, 2023 07:19
@NanoCode012 NanoCode012 force-pushed the chore/remove_peftcallback branch from 1e2bd08 to 8abfbed Compare September 22, 2023 02:17
@NanoCode012 NanoCode012 merged commit d5f8589 into axolotl-ai-cloud:main Sep 22, 2023
4 checks passed
@NanoCode012 NanoCode012 deleted the chore/remove_peftcallback branch September 22, 2023 03:31
mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants