-
-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic evaluate CLI command / codepath #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djsaunde
requested review from
winglian and
NanoCode012
and removed request for
winglian and
NanoCode012
December 16, 2024 17:03
winglian
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit on the print statement. Would be good to figure out a way to document that some of the evaluate/train code is duplicated so that we know to make changes in the other down the line. Otherwise lgtm
djsaunde
added a commit
that referenced
this pull request
Dec 16, 2024
* basic evaluate CLI command / codepath * tests for evaluate CLI command * fixes and cleanup * review comments; slightly DRYing up things --------- Co-authored-by: Dan Saunders <[email protected]>
djsaunde
added a commit
that referenced
this pull request
Dec 17, 2024
* basic evaluate CLI command / codepath * tests for evaluate CLI command * fixes and cleanup * review comments; slightly DRYing up things --------- Co-authored-by: Dan Saunders <[email protected]>
djsaunde
added a commit
that referenced
this pull request
Dec 17, 2024
* basic evaluate CLI command / codepath * tests for evaluate CLI command * fixes and cleanup * review comments; slightly DRYing up things --------- Co-authored-by: Dan Saunders <[email protected]>
djsaunde
added a commit
that referenced
this pull request
Dec 17, 2024
* basic evaluate CLI command / codepath * tests for evaluate CLI command * fixes and cleanup * review comments; slightly DRYing up things --------- Co-authored-by: Dan Saunders <[email protected]>
djsaunde
added a commit
that referenced
this pull request
Dec 17, 2024
* basic evaluate CLI command / codepath * tests for evaluate CLI command * fixes and cleanup * review comments; slightly DRYing up things --------- Co-authored-by: Dan Saunders <[email protected]>
djsaunde
added a commit
that referenced
this pull request
Dec 18, 2024
* basic evaluate CLI command / codepath * tests for evaluate CLI command * fixes and cleanup * review comments; slightly DRYing up things --------- Co-authored-by: Dan Saunders <[email protected]>
djsaunde
added a commit
that referenced
this pull request
Dec 20, 2024
* basic evaluate CLI command / codepath * tests for evaluate CLI command * fixes and cleanup * review comments; slightly DRYing up things --------- Co-authored-by: Dan Saunders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Title.
Motivation and Context
I'd like to use this codepath to validate my differential transformers work. I.e., when converting a base model to one where we've swapped out the attentions for (zero-init) differential attentions, we expect the loss to be the same as before the conversion.
This will be generally useful for evaluating models post training, comparing models apples-to-apples, evaluating on different datasets, etc.
How has this been tested?
Only basic testing in Runpod on a A40 instance with the
axolotlai/axolotl-cloud:main-latest
image.For example, with this simple config:
We get:
Types of changes
Adding a new top-level module
axolotl.evaluate
as well as a corresponding CLI moduleaxolotl.cli.evaluate
.Test coverage is still outstanding.Done.I'd also like to add evaluation on the training dataset (if passed).Done.