move the setting of PYTORCH_CUDA_ALLOC_CONF to the cli rather than train module #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djsaunde
approved these changes
Dec 13, 2024
NanoCode012
reviewed
Dec 13, 2024
src/axolotl/cli/main.py
Outdated
| if os.getenv("PYTORCH_CUDA_ALLOC_CONF") is None: | ||
| os.environ[ | ||
| "PYTORCH_CUDA_ALLOC_CONF" | ||
| ] = "expandable_segments:True,roundup_power2_divisions:16" |
There was a problem hiding this comment.
I'm just reading about this: roundup_power2_divisions config. Is there a reason we're setting 16? I saw that the default was 512.
There was a problem hiding this comment.
The default is 1 from what I've seen.
The doc you were reading says : the sizes are rounded up in multiple of blocks size of 512
Which is the block size, not the divisions
…loaded dependencies for the CLI
winglian
force-pushed
the
pytorch-cuda-alloc-conf
branch
from
1fb37c2 to
0e0c6d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed in the profiler that it said this wasn't set and moving it around reduced the reserved memory in the configuration I was using from 37GB to 27GB