Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce sample_packing FA error to warning #1484

Merged
merged 1 commit into from
Apr 6, 2024
+2 −2
Merged

fix: reduce sample_packing FA error to warning #1484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/axolotl/utils/config/models/input/v0_4_1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,8 +664,8 @@ def check_sample_packing_wo_flash(cls, data):
and not data.get("flash_attention")
and not data.get("sdp_attention")
):
raise ValueError(
"sample_packing requires flash_attention or sdp_attention to be set to true"
LOG.warning(
"sample_packing without flash_attention or sdp_attention does not handle cross-attention."
)

return data
Expand Down
Loading