make sure to capture non-null defaults from config validation #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winglian
force-pushed
the
fix-defaults-cfg
branch
from
0e5bfce to
15fdd03
Compare
winglian
force-pushed
the
fix-defaults-cfg
branch
from
97ff42b to
f50443b
Compare
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the defaults set in pydantic weren't being passed through to the
cfg, because the previous behavior was to exclude any unset vars b/c it was excessively noisy outputs.exclude_noneis a good compromise since the default getattr return value forcfg/DictDefaultisNone