FDSP + QLoRA #1378
Merged
FDSP + QLoRA #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm really excited about this |
hamelsmu
approved these changes
Mar 8, 2024
…c to qlora + fsdp
hamelsmu
reviewed
Mar 8, 2024
hamelsmu
reviewed
Mar 8, 2024
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
* wip qlora + fsdp fixes * more fixes * make sure to load the lora 🤦 * only setup quantized meta on non-zero rank: * only run setup_quantized_peft_meta_for_training for qlora+fsdp * more fixes for qlora+fsdp * chore: lint * add example yml * support mistral too * fix for model_type and add mixtral support too * set cpu_offload: false to reduce vram, constrain new accleerator logic to qlora + fsdp * refactor for duplicate code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AnswerAI managed to get qlora+fsdp working, taking a stab at implementing the fundamentals.
https://github.com/AnswerDotAI/fsdp_qlora/blob/47c17224b86425cd9cf03c1d7c760a5035656859/train.py
cc: @jph00 @johnowhitaker