Fix and document test_datasets #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filippo82
reviewed
Jan 29, 2024
winglian
reviewed
Jan 30, 2024
winglian
reviewed
Jan 31, 2024
winglian
approved these changes
Jan 31, 2024
|
👏🏻 |
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Make sure test_dataset are used and treat val_set_size. * Add test_datasets docs. * Apply suggestions from code review --------- Co-authored-by: Wing Lian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
test_datasetsand adds docs.Motivation and Context
There were a few bugs.
How has this been tested?
I ran several train runs with it. Only using json completion datasets, but that should be fine.
Social Handles (Optional)
dreamgen on discord
https://twitter.com/DreamGenAI