keep gate in fp32 for loras #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add lora tests @ 16bit and fix gate layer check fix the parameter name, was using the old disco name don't lora over the gate so we can check that is in fp32 fix dtype check
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
* keep gate in fp32 for loras * add e2e check for lora w/o flash attention for mixtral to check gate * add checks for gate in fp32 for mixtral, add typehints to train outputs * mixtral doesn't support basic lora 🤦 add lora tests @ 16bit and fix gate layer check fix the parameter name, was using the old disco name don't lora over the gate so we can check that is in fp32 fix dtype check * ensure we're using fp16/bf16 for 16bit and qlora is always going to be in uint8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.