fix: train_on_inputs: true ignored for sharegpt
#1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoCode012
commented
Jan 5, 2024
|
It would be good to have unit tests that verify this functionality. I can help with this over the weekend. |
winglian
force-pushed
the
fix/train_on_inputs_sharegpt
branch
from
dd8dc4d to
5ad17c7
Compare
|
@NanoCode012 I added a test for this to #1054 , but it's commented out for now since it's failing until this is rebased over that |
|
You can merge that first then. This can come after |
winglian
force-pushed
the
fix/train_on_inputs_sharegpt
branch
from
5ad17c7 to
9b75ae0
Compare
|
Looks good! |
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
* fix: `train_on_inputs: true` ignored for sharegpt * enable unit test for train_on_inputs for sharegpt --------- Co-authored-by: Wing Lian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this discussion here: https://discord.com/channels/1104757954588196865/1192621815172964522
Sharegpt conversation masks all the time and does not respect
train_on_inputs. This PR fixes it.