-
-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: warn user to install mamba_ssm package #1019
fix: warn user to install mamba_ssm package #1019
Conversation
Do you think this needs to be added to
|
I also wonder if a mamba smoke test of some kind is a good idea? |
Yes, that's what I thought about as well. To what extent should we add these in? This package is optional. Should we add a table like in https://github.com/EleutherAI/lm-evaluation-harness#install to show dependency?
What kind of test do you have in mind? |
For the smoke test, maybe something like we have with the tiny mistral here? I really like that test because its super fast but still catches errors. The 130M param one maybe? what do you think? |
Is this our first optional dependency? For example is flash attention an optional dependency too? Maybe keep it in requirements.txt for consistency right now, until we organize all the optional dependencies together somehow? By the way, now that I think of it, I think the README is confusing because
Should really just be
because |
Ah, I asked caseus about this as well. This was due to some CI issue with installing FA and deepspeed at same time as other packages. Hence the |
Hmm maybe it's best to wait for @winglian to comment then - CI issues can be nasty 😃 |
726dfe0
to
e109433
Compare
Oh gosh. Yeah. I struggled with the flash attn w CI for a solid day. I think we should at some point try to clean up all the dependencies, but maybe not for this particular issue. I thi knits probably fine to just make mamba a required dependency as long as it doesn't have too many version specific pins that might conflict with upgrades we'll make down the line. |
@NanoCode012 i approved PR so you can merge after adding the dependency to requirements.txt |
Hm, I wonder if we need to move mamba installation out, just like flash now.. It's asking for packaging, which is being installed at same time. |
5bb2069
to
47bf7d9
Compare
47bf7d9
to
f2a975d
Compare
Fixes #975 . Warns when user does not have package installed.