don't add position_ids for evals (#591)

axolotl-ai-cloud · Sep 16, 2023 · ab534d7 · ab534d7
1 parent 21ec195
commit ab534d7
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/axolotl/utils/trainer.py b/src/axolotl/utils/trainer.py
@@ -403,10 +403,11 @@ def process_datasets_for_packing(cfg, train_dataset, eval_dataset):
 
         if cfg.sample_packing:
             train_dataset = train_dataset.map(add_position_ids, num_proc=os.cpu_count())
-            if eval_dataset:
-                eval_dataset = eval_dataset.map(
-                    add_position_ids, num_proc=os.cpu_count()
-                )
+            if cfg.eval_sample_packing is not False:
+                if eval_dataset:
+                    eval_dataset = eval_dataset.map(
+                        add_position_ids, num_proc=os.cpu_count()
+                    )
     return train_dataset, eval_dataset