don't add dataset tags if empty due to all local data paths (#2162) […

…skip ci]
axolotl-ai-cloud · Dec 9, 2024 · 3862267 · 3862267
1 parent c78de6f
commit 3862267
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/axolotl/train.py b/src/axolotl/train.py
@@ -267,13 +267,19 @@ def terminate_handler(_, __, model_weakref):
             }
             if cfg.datasets is not None:
                 if cfg.rl is not None or cfg.reward_model:
-                    model_card_kwarg["dataset_name"] = [
+                    dataset_tags = [
                         d["path"] for d in cfg.datasets if not Path(d["path"]).is_dir()
                     ]
+                    if dataset_tags:
+                        # guard as create_model_card may fail if dataset_tags is empty list
+                        model_card_kwarg["dataset_name"] = dataset_tags
                 else:
-                    model_card_kwarg["dataset_tags"] = [
+                    dataset_tags = [
                         d["path"] for d in cfg.datasets if not Path(d["path"]).is_dir()
                     ]
+                    if dataset_tags:
+                        # guard as create_model_card may fail if dataset_tags is empty list
+                        model_card_kwarg["dataset_tags"] = dataset_tags
 
             trainer.create_model_card(**model_card_kwarg)
         except (AttributeError, UnicodeDecodeError):