Skip to content

Commit

Permalink
multipack len should use max, not min (#863)
Browse files Browse the repository at this point in the history
  • Loading branch information
winglian authored Nov 15, 2023
1 parent db8a8af commit 0c2a630
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/axolotl/utils/samplers/multipack.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def _len_est(self):
)

# shave off 1% + 1 for dealing with variance in packing from random sampler to sampler
return min(
return max(
1,
(
world_size
Expand Down

0 comments on commit 0c2a630

Please sign in to comment.