Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent excessive calls to deleteBackward method which may cause crashes on Android #2248

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

rh101
Copy link
Contributor

@rh101 rh101 commented Nov 26, 2024

Describe your changes

The changes in this PR will prevent situations where a call to TextField::deleteBackward is made for every single character when deleting text in large blocks, such as via a Select All -> Backspace operation using the Android virtual keyboard. When many consecutive calls to deleteBackward are made in a single update/frame, it seems to result in a crash.

Just note that this does not change the behavior when the user is deleting one character at a time, since it will still call TextField::deleteBackward once per character. The test cases in cpp-tests, 49:Node: Text Input confirm that the behaviour is still the same.

Issue ticket number and link

This possibly relates to all the following issues:
#2240
#2241
#2242

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant