Prevent excessive calls to deleteBackward method which may cause crashes on Android #2248
+65
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The changes in this PR will prevent situations where a call to
TextField::deleteBackward
is made for every single character when deleting text in large blocks, such as via a Select All -> Backspace operation using the Android virtual keyboard. When many consecutive calls todeleteBackward
are made in a single update/frame, it seems to result in a crash.Just note that this does not change the behavior when the user is deleting one character at a time, since it will still call
TextField::deleteBackward
once per character. The test cases in cpp-tests,49:Node: Text Input
confirm that the behaviour is still the same.Issue ticket number and link
This possibly relates to all the following issues:
#2240
#2241
#2242
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."
I have performed a self-review of my code.
Optional:
For core/new feature PR