Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables support for mipmapped textures in Metal. In Metal, mipmaps were ignored, because
mipFilter
forMTLSamplerDescriptor
was never set.Note: new graphic APIs like Metal do not support separate mipmap filters for minifying and magnifying textures, so I had to make a compromise and derive mip filter from the mag filter. I think in the future it would be best to change
SamplerFilter
enum to contain onlyLINEAR
andNEAREST
values and addSamplerMipFilter
enum to containLINEAR
,NEAREST
,NONE
and inSamplerDescriptor
addSamplerMipFilter mipFilter
field.