Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go to 1.22 #61

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Update go to 1.22 #61

merged 2 commits into from
Apr 5, 2024

Conversation

smorimoto
Copy link
Contributor

No description provided.

Copy link
Contributor

@lukasmalkmus lukasmalkmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
@lukasmalkmus lukasmalkmus enabled auto-merge (rebase) April 5, 2024 10:26
@lukasmalkmus lukasmalkmus merged commit a2faf55 into axiomhq:main Apr 5, 2024
3 checks passed
@smorimoto smorimoto deleted the go-1.22 branch April 5, 2024 11:22
@lukasmalkmus
Copy link
Contributor

lukasmalkmus commented Apr 5, 2024

@smorimoto The bump of golangci-lint resulted in some new linting problems discovered on the main branch: https://github.com/axiomhq/axiom-syslog-proxy/actions/runs/8568431586.

I think it wasn't discovered on this PR because CI is configured to only fail on "new" linter issues. And I think "new" in that context means "newly introduced code that doesn't pass linting". Sorry I can't give you a more elaborate answer at this point, need to investigate.

But the failures look rather simple. Would you mind taking a look at fixing those? Otherwise I put it on my list. make lint should be your friend :D Looks like you just need to underscore (_) some unused params.

@smorimoto
Copy link
Contributor Author

Sure!

@smorimoto smorimoto mentioned this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants