fix(flusher): Retry flush on exit #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahlo
changed the title
The flusher keeps a batch of events so retrying doesn't make sense when we'll flush again with the next event. But on exit there won't be a next event, so we need to retry there. Because you can't set the retry behaviour after constructing an Axiom client, this creates a second one that retries and adds a `RetryOpt` to the `Flush` method.
bahlo
force-pushed
the
arne/fix-flush-on-exit
branch
from
0167347 to
48e92ea
Compare
dasfmi
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flusher keeps a batch of events so retrying doesn't make sense when we'll flush again with the next event.
But on exit there won't be a next event, so we need to retry there.
Because you can't set the retry behaviour after constructing an Axiom client, this creates a second one that retries and adds a
RetryOptto theFlushmethod.