-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Sveltekit package and example issues #207
Conversation
Fixing Sveltekit package issues and its implementation in example app
hey @jerriclynsjohn, great work! I see you are very excited for this, I will take a look in the next couple of days and help get this released 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good, there is one thing I am concerned about. The source
field, I wanted to make that as simple and limited as possible so that we can build dashboards easily using it. I imagine hooks-server
and hooks-client
+ others, will make it more complex, we need to think how to simplify this. maybe ['source']
+ ['browser']
would indicate if its a client or server. or maybe we can introduce a filename field or something? wdyt?
|
It would actually help to custom name it in |
Lets start with just |
@schehata Renamed it all to just |
As discussed in #198 I'm adding the suggested changes.