Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Dependabot to check that the base image is up to date #19

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

abkfenris
Copy link
Collaborator

Extends #18 with Dependabot checking the base image to make sure it is up to date weekly.

Additionally it adds Github Actions to check each push to the repo to make sure the image can be build, launched, and will return a 200 from the default ERDDAP page.

When a commit is to the main or master branch in Axiom's repo, Github Actions will then push the latest image to Docker Hub. (This requires DOCKER_USERNAME and DOCKER_PASSWORD secrets to be setup in the repo, which will also be used to authenticate pulling of Docker images to avoid rate limiting)

Extends axiom-data-science#18 with Dependabot checking the base image to make sure it is up to date weekly.
Github actions checks each push to make sure the image can be build, launched, and will return a 200 from the default ERDDAP page.
When a commit is to the main or master branch, then the built image will be pushed to Docker Hub (if appropriate secrets are setup, and it is to Axiom's repo).
@abkfenris
Copy link
Collaborator Author

@kwilcox It looks like actions might have to be enabled in addition to the secrets. Here is what the action workflow looks like on my fork.

I think I can also create a scheduled Github Actions workflow to make an issue when there is a new release of ERDDAP, so that someone can manually build, test, and push updated images.

@kwilcox
Copy link
Collaborator

kwilcox commented Jan 4, 2021

I created the secrets, let's see what happens on merge.

I think I can also create a scheduled Github Actions workflow to make an issue when there is a new release of ERDDAP, so that someone can manually build, test, and push updated images.

that would be fabulous

@kwilcox kwilcox merged commit 24d4d08 into axiom-data-science:master Jan 4, 2021
@abkfenris
Copy link
Collaborator Author

Hmm, the Docker cache didn't work as expected. Let me take a look

@kwilcox
Copy link
Collaborator

kwilcox commented Jan 4, 2021

It looks like the docker image cache isn't working so the built image isn't available for push

Root cache could not be found. aborting.

Yup, what you said!

@abkfenris
Copy link
Collaborator Author

It looks like the caching action doesn't play nicely with images specified by digest.

I'm going to explore using the new buildx builder to see if that will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants