Skip to content

Commit

Permalink
[chore] separate revm import into separate feature (#44)
Browse files Browse the repository at this point in the history
* chore: import `ruint` separately to not rely on `revm`

* feat: add feature `revm` to toggle `revm` import

Separates `revm` import, which is only used for testing EVM execution,
from `loader_evm` feature, which is used more broadly for generating
proofs to be sent to on-chain verifier.

* chore: add CI to check `--release` compilation with assembly

* fix: import under revm
  • Loading branch information
jonathanpwang authored Nov 4, 2023
1 parent 055527a commit 1cf2986
Show file tree
Hide file tree
Showing 13 changed files with 3,380 additions and 38 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ jobs:
run: (hash svm 2>/dev/null || cargo install --version 0.2.23 svm-rs) && svm install 0.8.19 && solc --version

- name: Run test
run: cargo test --all -- --nocapture
run: cargo test --all --features "revm" -- --nocapture

- name: Run example
working-directory: "snark-verifier-sdk"
run: cargo run --example standard_plonk
run: cargo run --example standard_plonk --features "revm"

lint:
name: Lint
Expand Down
36 changes: 36 additions & 0 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
name: CI

on:
pull_request:
branches:
- ["main", "release-*"]
push:
branches:
- main

jobs:
test:
name: Test assembly release
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2

- name: Install toolchain
uses: actions-rs/toolchain@v1
with:
profile: minimal
override: false

- uses: Swatinem/rust-cache@v1
with:
cache-on-failure: true

- name: Install solc
run: (hash svm 2>/dev/null || cargo install --version 0.2.23 svm-rs) && svm install 0.8.19 && solc --version

- name: Run test
run: cargo test --all --features "revm, halo2-base/asm" -- --nocapture

- name: Run example
working-directory: "snark-verifier-sdk"
run: cargo run --example standard_plonk --features "revm, halo2-base/asm"
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
/target
testdata

Cargo.lock
# Cargo.lock
params
agg.pk
break_points.json
break_points.json
Loading

0 comments on commit 1cf2986

Please sign in to comment.