Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] openvm sha2 #14

Merged
merged 8 commits into from
Jan 8, 2025
Merged

[feat] openvm sha2 #14

merged 8 commits into from
Jan 8, 2025

Conversation

luffykai
Copy link
Collaborator

@luffykai luffykai commented Jan 6, 2025 •
edited
Loading

redo #8

fix INT-2876

@luffykai luffykai marked this pull request as ready for review January 7, 2025 07:57
@luffykai luffykai requested a review from jonathanpwang January 7, 2025 07:57
jonathanpwang
jonathanpwang approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathanpwang
Copy link
Contributor

I think we aren't running tests in CI, can we quickly add a workflow?

@luffykai luffykai merged commit 0457ae5 into v43-openvm Jan 8, 2025
1 check passed
@luffykai luffykai deleted the lunkai/sha2 branch January 8, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpwang jonathanpwang jonathanpwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luffykai @jonathanpwang @arayikhalatyan