-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow grumphp-shim to 2.x version. #27
Allow grumphp-shim to 2.x version. #27
Conversation
Thanks, @rajeshreeputra. Is there any reason we should keep support for v1 of the shim? I don't think it has dependencies and so chances of conflicts with other packages is unlikely. |
Agree Updated to use 2.x version. Thank you!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work so far. Please look at my comment.
@hussainweb when can we expect a release. |
@rajeshreeputra, since this is going to be a breaking release, I will release a new major version. For that, I wanted to change a few more things. Can I get your thoughts on #12 and #21? I also created #29 for a generic discussion. |
I believe a major version isn't necessary in this case; version 1.4.0 should suffice for this. |
Since we are moving to a new major version of a major dependency (GrumPHP), it is a good idea to make a new major release. I don't know what's changed between GrumPHP 1 and 2 but if there are significant changes, then users have to consciously choose to update. |
Fixes #25