feat(evm)!: update evm examples with AxelarExecutable and AxelarExecutableWithToken #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahramy
commented
Aug 29, 2024
ahramy
commented
Aug 29, 2024
ahramy
changed the title
ahramy
requested review from
benjamin852 and
StephenFluin
and removed request for
Foivos
ahramy
changed the title
ahramy
changed the title
|
@ahramy left some comments. Let me know what you think. Feel free to assign the pr back to me once you take a look, thanks! |
benjamin852
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
@ahramy Getting this warning when I run example locally bigint: Failed to load bindings, pure JS will be used (try npm run rebuild?). Not a blocker example still runs but not sure why this warning appears.
examples/evm/call-contract-with-token-express/CallContractWithTokenExpress.sol
Show resolved
Hide resolved
ahramy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Message:
As part of EVM ITS V2,
axelar-gmp-sdk-soliditywas refactored to use AxelarGMPExecutable and AxelarGMPExecutableWithToken (PR #181).axelar-examplesare also required to inherit from the AxelarGMPExecutable and AxelarGMPExecutableWithToken.Updated - Naming changed to :
Ticket: AXE-4723, AXE-5796