-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce native support for config stores, core, SQS and SNS module #856
base: main
Are you sure you want to change the base?
Conversation
@MatejNedic nice to see there's a movement towards native build support, are there any rough estimates when this PR will be merged? |
Hey hey @romangr , hopefully soon! Will work on this during a weekend |
@MatejNedic cool, thank you for your work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to run all our integration tests in a context of native image? As much as I believe that this PR works, how can we ensure that all functionality added in the future also works in the context of native image?
...d-aws-autoconfigure/src/main/java/io/awspring/cloud/autoconfigure/config/ConfigStoreAOT.java
Outdated
Show resolved
Hide resolved
@maciejwalkowiak @tomazfernandes Let merge this I have tested it and it works properly. We can always add hints when people report issues. |
# Conflicts: # spring-cloud-aws-dependencies/pom.xml # spring-cloud-aws-s3/src/main/java/io/awspring/cloud/s3/S3RuntimeHints.java
Hey @MatejNedic and @maciejwalkowiak - just a heads up - there is a new version for AWS SDK V2 and AWS CRT which both supports Spring Boot Native, now - see: aws/aws-sdk-java-v2#5290 / aws/aws-sdk-java-v2#5184 and awslabs/aws-crt-java#749 Can you bump the version of the AWS SDK V2 to a newer version? This is important when you want to use the S3TransferManager to use Multipart-Uploads |
Hey @klopfdreh , |
When this PR will be merged? 😄 Currently we have to take care of resource and everthing else like: {
"resources": [
{
"pattern": "io/awspring/cloud/core/SpringCloudClientConfiguration.properties"
},
{
"pattern": "io/awspring/cloud/s3/S3ObjectContentTypeResolver.properties"
}
]
} and all other stuff you wrote hints for. |
@maciejwalkowiak lets merge this and release it in 3.2.0 |
@MatejNedic , any reason why this is not compatible with 3.1.2? |
When are we going to get this PR merged? |
📢 Type of change
📜 Description
Currently creating native image for using core, both configs, SQS and SNS work and polls on start of native executable.
Closes #673 and partially #468
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps