Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly deserialize lists with @SnsNotificationMessage #1282

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Properly deserialize lists with @SnsNotificationMessage #1282

wants to merge 1 commit into from

Conversation

frjonsen
Copy link

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

When deserialization target is a list, get the inner type

💡 Motivation and Context

#1280

💚 How did you test it?

Modifying the existing test to access the actual fields of the deserialized objects

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

@github-actions github-actions bot added the component: sqs SQS integration related issue label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejwalkowiak maciejwalkowiak Awaiting requested review from maciejwalkowiak maciejwalkowiak is a code owner

@MatejNedic MatejNedic Awaiting requested review from MatejNedic MatejNedic is a code owner

@tomazfernandes tomazfernandes Awaiting requested review from tomazfernandes tomazfernandes is a code owner

Assignees
No one assigned
Labels
component: sqs SQS integration related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frjonsen